fix(matchmaker): update total count after rounding to CountMultiple #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After roundToCountMultiple successfully removes some tickets to satisfy CountMultiple we need to update total number of players in the candidate match (found combo + current index) Previously final Min/Max/Multiple count check for each selected ticket (MatchmakerIndex) was done against stale total count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After roundToCountMultiple successfully removes some tickets to satisfy CountMultiple we need to update total number of players in the candidate match (found combo + current index)
Previously final Min/Max/Multiple count check for each selected ticket (MatchmakerIndex) was done against stale total count.
NOTE: Bug is present in master, but PR targets in progress readability PR, not master