Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split matchmaker.Process into smaller functions for readability #943

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Split matchmaker.Process into smaller functions for readability #943

wants to merge 10 commits into from

Commits on Nov 7, 2022

  1. some basic docstrings

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    937b262 View commit details
    Browse the repository at this point in the history

  2. chore(matchmaker): variable rename for better clarity

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1b672ca View commit details
    Browse the repository at this point in the history

  3. chore(matchmaker): extract some logic into dedicated methods

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0ebd6bb View commit details
    Browse the repository at this point in the history

  4. chore(matchmaker): don't pass always empty slice as param

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7bdab22 View commit details
    Browse the repository at this point in the history

  5. chore(matchmaker): extract logic into sendMatchmakingResult method

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    092eacf View commit details
    Browse the repository at this point in the history

  6. chore(matchmaker): trivial time operation simplification

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1933270 View commit details
    Browse the repository at this point in the history

  7. chore(matchmaker): extract hit conflict check into dedicated method

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9e6ba19 View commit details
    Browse the repository at this point in the history

  8. chore(matchmaker): allow mutual index conflict check

    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8de9f0f View commit details
    Browse the repository at this point in the history

  9. chore(matchmaker): check conflict between entries and with existing f… 

    …unction
    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ccf77ab View commit details
    Browse the repository at this point in the history

  10. chore(matchmaker): run matchmaking loop on index, not entries 

    atomic unit of matchmaking is matchmaking index, but MM logic used to operate
on entries, which required converting to index in multiple places.

This commits makes MM loop to operate on indexes, producing final entries
only at the very end.
    @redbaron
    redbaron committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    19b9ecf View commit details
    Browse the repository at this point in the history