Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to custom sorting in storage index search #1168

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

hexun80149128
Copy link

https://forum.heroiclabs.com/t/does-the-query-in-storageindexlist-support-sorting-and-how/4948
currently storage index listing does not support sorting the results.so add it。thanks

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024

CLA assistant check
All committers have signed the CLA.

@ftkg
Copy link
Contributor

ftkg commented Feb 16, 2024

We probably also want to index the fields with the Sortable() property before doing requests with custom sorts on them, as specified in the docs.

@hexun80149128
Copy link
Author

RegisterStorageIndex add sortFields param.it must be in fields,and should be string or num. @ftkg

server/storage_index.go Outdated Show resolved Hide resolved
@ftkg ftkg changed the title StorageIndexList add order param Add support to custom sorting in storage index search Mar 8, 2024
@ftkg
Copy link
Contributor

ftkg commented Mar 8, 2024

nakama-common PR: heroiclabs/nakama-common#142

@hexun80149128
Copy link
Author

@ftkg can merge to master next version?

@hexun80149128 hexun80149128 requested a review from ftkg March 27, 2024 01:45
@sesposito
Copy link
Member

@ftkg please add a changelog entry as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants