New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to custom sorting in storage index search #1168
Open
hexun80149128
wants to merge
13
commits into
heroiclabs:master
Choose a base branch
from
hexun80149128:f_StorageIndexList
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support to custom sorting in storage index search #1168
hexun80149128
wants to merge
13
commits into
heroiclabs:master
from
hexun80149128:f_StorageIndexList
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We probably also want to index the fields with the |
RegisterStorageIndex add sortFields param.it must be in fields,and should be string or num. @ftkg |
ftkg
reviewed
Feb 20, 2024
…with custom sorts
…the sortFilters must start with value.
…ers,and the sortFilters must start with value." This reverts commit 5f06e2b.
ftkg
changed the title
StorageIndexList add order param
Add support to custom sorting in storage index search
Mar 8, 2024
|
@ftkg can merge to master next version? |
sesposito
approved these changes
May 9, 2024
@ftkg please add a changelog entry as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.heroiclabs.com/t/does-the-query-in-storageindexlist-support-sorting-and-how/4948
currently storage index listing does not support sorting the results.so add it。thanks