when ProcessRequest is false and it sends error message to chan, the … #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nakama-js can be timeout because the IncomingLoop is break. We need to add a flag to break IncomingLoop safely
|
|
|
I am facing the same problem, please consider to merge this one |
|
The PR and code change is not descriptive enough.
I ask these questions because we've never seen an issue in this code path. |
|
I create this issue #1164 for describe the problem what I am facing with. Please take a look. The timeout message will appear after 10 seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #1164
nakama-js can be timeout because the IncomingLoop is break. We need to add a flag to break IncomingLoop safely