Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nakama-js can be timeout when pipeline.ProcessRequest return false #1164

Open
1 task
nguyentrannhan opened this issue Feb 2, 2024 · 2 comments
Open
1 task

Comments

@nguyentrannhan
Copy link

Description

When pipeline.ProcessRequest return false, the nakama-js can be timeout because the IncommingLoop is break. To fix it, we add a flag for safely break the IncommingLoop

Steps to Reproduce

  1. Run nakama-js-webpack-example
  2. Run joinChat with wrong input
  3. Errors reported to client and in console log

Expected Result

nakama-js should return with invalid input error not socket timeout

Actual Result

Error is thrown with socket timeout

Context

  • nakama-js

Your Environment

  • Nakama: 2.7.1
  • Database: CockroachDB
  • Environment name and version: Development
  • Operating System and version: Window 10/Ubuntu 20.04
Copy link

linear bot commented Feb 2, 2024

@ftkg
Copy link
Contributor

ftkg commented Feb 16, 2024

I don't understand what the issue is supposed to be here and its attempted fix. If you are sending a malformed payload that cannot be processed, the socket will be closed as intended. What is the "wrong input" you are sending in joinChat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants