Automated socket reconnect #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lugehorsam
force-pushed
the
luke/socket-reconnect
branch
from
841c14f
to
5182ab8
Compare
|
Are there any known issues that need to be addressed before this is ready to merge in? I'd like to use this instead of implementing my own socket keep-alive logic. |
|
@LobsterUberlord The socket code was refactored earlier in the week so I'll need to rework this code to support socket-based reconnects: 6811339 This code can't be rebased and merged in its current form. If you're interested to introduce a pull request to bring this logic into the SDK I'd be happy to review it for you. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOException.autoReconnecttofalse. The reason I did this is in case users have existing code doing socket reconnects. If they upgrade and forgot to change atrueparameter, they would be "double reconnecting" in the case of disconnects.