Refactored rest client #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with error model.
lugehorsam
reviewed
May 24, 2024
lugehorsam
reviewed
May 24, 2024
lugehorsam
reviewed
May 24, 2024
lugehorsam
reviewed
May 24, 2024
lugehorsam
reviewed
May 24, 2024
lugehorsam
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR mainly aims to fix the rest client response null issues due to response fields being in a snake_case.
• Ditch chopper and use code generator with retrofit for rest client APIs.
• Add missing socket party functions: accept/remove members and close.
• Enhance functions interface by hiding internal models and using client defined models.
• Add missing client functions: importFacebookFriends and importSteamFriends.
• Add documentation comments for client functions.
• Revised tests.