Add geojson compliant decoding parameter #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Baker <jbaker@freightwaves.com>
jtbaker
force-pushed
the
feature/geojson-decoding
branch
from
2ad5f58
to
0b4fc9f
Compare
Jordan-Work
reviewed
Mar 23, 2021
| let point | ||
|
|
||
| if (geojson) { | ||
| point = [lastLng, lastLat] |
There was a problem hiding this comment.
(L31,54,56)
Hey may want to toss a ; on these I've got caught doing that too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33
GeoJSON spec specifies that coordinates be ordered as
x, ycoordinate pairs. This PR adds aparamsobject argument with ageojsonvalue that defaults to false (having no effect on the default function call).If
decode(<polyline>, {geojson: true})is passed, however, the points will come back ordered according to the spec. This provides a similar interface to Uber's H3 Bindings in JS. This is useful because it prevents clients needing polyline coordinates to interface with GeoJSON from needing to loop/map through the array again to flip the coordinates around.