No max operation in formulas #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavpanchekha
approved these changes
Apr 30, 2024
src/correct-round.rkt
Outdated
| (define x (first srcs)) | ||
| (define y (second srcs)) | ||
|
|
||
| (define x-exp (ival-max-log2-approx x)) | ||
| (define y-exp (ival-max-log2-approx y)) | ||
| (define out-exp (ival-min-log2-approx output)) | ||
|
|
||
| (make-list 2 (max 0 (- (+ x-exp y-exp) (* 2 (max x-exp y-exp)) out-exp)))] | ||
| (make-list 2 (+ (- (+ x-exp y-exp) (* 2 (min x-exp y-exp)) out-exp) 1))] |
There was a problem hiding this comment.
This one was tricky. Turned out that I was over-approximating sum of logs, when it actually had to be under-approximated since we subtract this value. The overall exponent will be over-approximated with this change. Previously it was not enough
|
I've already reviewed this, if the nightly is good just merge it. |
|
And nightly looks great, just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces a change to the tuning formulas.
maxoperation was removed and now exponents can be negative as well.Nevertheless, the final precision can not be less than
*base-tuning-bits*, which is set to 73.This feature saves some precision during sampling and localize when number of iteration > 0.