feat(helm): add --app-version flag to 'helm install/upgrade' #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a step required every time we release Helm, making it simpler to cut a new release. Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
…lm upgrade' When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include the notes from the subchart when rendered via Tiller. Closes helm#2751 Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: jgleonard <jgleonard@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
The output from helm status is not correct for custom resources. The HumanReadablePrinter from Kubernetes only outputs the column names when the type differs from the previous one. This makes the output inconsistent and also creates problems for putting in the correct line breaks. This PR sets up a new printer for each type, thereby making sure that all types are printed with the correct use of line breaks and with column names. Signed-off-by: Morten Torkildsen <mortent@google.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
helm-bot
added
size/M
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
…elm#4952) * error message for creating multiple helm chart at a time Signed-off-by: hanif <abuhanifa@pathao.com> * Update cmd/helm/create.go Co-Authored-By: a8uhnf <a8uhnf@users.noreply.github.com> Signed-off-by: hanif <abuhanifa@pathao.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
|
Hey, would you mind rebasing to ensure that the windows tests work? We fixed them up in #4897. Sorry for the trouble! |
* docs: add documentation for the helmignore file Signed-off-by: Ishaan Malhi <ishaan.malhi@gmail.com> * docs: rearrange helmignore docs under chart template developer's guide Signed-off-by: Ishaan Malhi <ishaan.malhi@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Due to a regression from a previous change, details about pod resources does not show up in the status output. This makes sure that the pod type from core are passed in to the printer so the details are shown in the output. Signed-off-by: Morten Torkildsen <mortent@google.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Apply the same procedure to allow missing trailing slash in repo base URLs used in `repo/chart` inputs to `--repo` inputs. Fixes helm#4954. Signed-off-by: Luke Hoban <luke@pulumi.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
…ployed revision Signed-off-by: Matt Tucker <ultimateboy@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
fix(storage): when pruning release versions, never delete the last deployed revision Signed-off-by: Kevin Labesse <kevin@labesse.me>
When 'helm install/upgrade --app-version 1.0.0' is run, this will override the chart app version Closes helm#3555 Signed-off-by: Kevin Labesse <kevin@labesse.me> docs(helm): add --app-version flags for 'helm install/upgrade' Signed-off-by: Kevin Labesse <kevin@labesse.me>
eraac
force-pushed
the
feat/app-version
branch
from
51404a8
to
8ddaa4e
Compare
helm-bot
added
size/M
* avoid kubernetes import for slice contains logic Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com> * fix review comments Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
While deving at a Microsoft Open Hack my group discovered this useful piece of information in this issue comment: helm#1796 (comment) We found it very useful for our Blue Green CD pipeline and thought others might find it useful as well. Signed-off-by: Ethan Arrowood <ethan.arrowood@gmail.com> Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Kevin Labesse <kevin@labesse.me>
* Update using_helm.md In docs/using_helm.md, it says on line 214 that you can pass in a YAML formatted file, but the example commands following that sentence create JSON code but names the file with a .yml extension. For clarity, I propose saying that it will accept JSON or YAML but clarify in the code that for the example we're making a JSON file. Signed-off-by: Pablo Canseco <p@blocanse.co> * update using_helm.md to accurately say that helm install -f only takes a yaml-formatted file. Signed-off-by: Pablo Canseco <p@blocanse.co> * updated wording to reflect the fact that -f / --values only accepts YAML Signed-off-by: Pablo Canseco <p@blocanse.co> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Jacob Silva <jacob.silva0123@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Marcin Kłopotek <marcin.klopotek@gmail.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: xichengliudui <1693291525@qq.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Kevin Labesse <kevin@labesse.me>
helm-bot
added
size/M
|
We have exactly the above use case @bacongobbler , common chart for 100s of app deployment, want this feature mucho (here is a helm ls). It'd be great if I could programatically set the appVersion at deploy time which means I'd be able to populate appVersion in this list with something which correlates to the application code revision (eg their pipeline build number). |
|
We too have the exact same case where we want to separate our docker image builds and helm charts...So that only when our code changes should result in change in docker image and not helm chart. It would be very great to see this feature |
|
@bacongobbler I understand initially |
bacongobbler
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
I have no alternative proposals on how to fix this, so I don't think we should be blocking the pragmatic solution from going forward.
@technosophos or @adamreese when either of you have a minute, would you mind taking a look at this and see if this seems like an okay approach to move forward?
helm-bot
added
size/L
helm-bot
added
size/L
helm-bot
added
size/XXL
helm-bot
added
size/XXL
|
My bad ... destroying git history, i will create new pull request |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'helm install/upgrade --app-version 1.0.0' is run, this will override the chart app version
Closes #3555
Signed-off-by: Kevin Labesse kevin@labesse.me
Waiting for your feedback, not 100% sure is the most efficient way do to that