Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): filter helm list to print latest release #3335

Merged
merged 1 commit into from Jan 12, 2018
Merged

fix(helm): filter helm list to print latest release #3335

merged 1 commit into from Jan 12, 2018

Conversation

adamreese
Copy link
Member

helm list should only list latest release

fixes #3208

@adamreese
fix(helm): filter helm list to print latest release
850db30 
`helm list` should only list latest release

fixes helm#3208
@adamreese adamreese self-assigned this Jan 11, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2018
technosophos
technosophos approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adam and I discussed this solution at length, and I think this is the best way to fix 3208.

@adamreese adamreese merged commit e9203b8 into helm:master Jan 12, 2018
@adamreese adamreese deleted the fix/3208-list-unique-releases branch January 12, 2018 00:25
@rcorre
Copy link

rcorre commented Jan 12, 2018

This doesn't resolve the inability to upgrade a deleted release mentioned in #3208. Should a separate issue be opened for that?

@bacongobbler bacongobbler mentioned this pull request Jan 15, 2018
Closed
@AmazingTurtle
Copy link

@technosophos who are you to close #3208 based on your discussion with your colleague? At least provide information on how you came to that conclusion. Because @rcorre is right, the inabilities have not been fixed with that. Please consider reopening the issue #3208

@michelleN
Copy link
Member

michelleN commented May 14, 2019 •
edited

@technosophos is the founder of this project and @adamreese is a founding engineer. Both are also Helm org maintainers and have been working on this project since its inception. Feel free to see our governance document and our MAINTAINERS document.

If you have a problem or would like further information, you can open a new issue. I'd also suggest you state your issues in a more respectful manner as our code of conduct dictates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

Assignees

@adamreese adamreese

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm upgrade --install no longer works
6 participants
@adamreese @rcorre @AmazingTurtle @michelleN @technosophos @k8s-ci-robot