Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[ci] Upgrade to chart-testing v2.4.0 #18538

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Conversation

unguiculus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2019
@unguiculus
Copy link
Member Author

/retest

1 similar comment
@unguiculus
Copy link
Member Author

/retest

@unguiculus
Copy link
Member Author

Initially the upgrade failed due to a missing API service.

See helm/helm#6361.

@unguiculus
Copy link
Member Author

/cc @helm/charts-maintainers

@k8s-ci-robot k8s-ci-robot requested a review from a team November 3, 2019 13:54
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2019
@cpanato
Copy link
Member

cpanato commented Nov 3, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2019
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2019
@unguiculus unguiculus marked this pull request as ready for review November 3, 2019 14:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2019
@unguiculus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2019
@cpanato
Copy link
Member

cpanato commented Nov 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dd935b3 into helm:master Nov 3, 2019
@unguiculus unguiculus deleted the upgrade-ct branch November 3, 2019 15:11
eMCeee89 pushed a commit to eMCeee89/charts that referenced this pull request Nov 3, 2019
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants