[stable/filebeat] set default config empty

[kimxogus]

Signed-off-by: Taehyun Kim kgyoo8232@gmail.com

What this PR does / why we need it:

#12199

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes filebeat's [stable/kibana,metricbeat,filebeat] default config is merged to user defined config #12199 issue

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[k8s-ci-robot]

Hi @kimxogus. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kimxogus]

/assign @sstarcher

[sstarcher]

So by default this will do pretty much nothing. Any reason you could not override the values that you want? I don't believe setting the default setting to be useless is a good move and we should consider something else.

[cdenneen]

helm/helm#5184 if working properly means you can override the output.file to null "remove" it but it doesn't seem to be working properly. If this worked properly you most likely wouldn't need to have empty configuration?

[kimxogus]

@sstarcher prospector was deprecated since 6.3, and deprecation warning log is printed in this chart.
Setting filebeat.prospectors as null or empty list [] couldn't unset prospectors, so filebeat.inputs can't be used.

[sstarcher]

That's fine so this configuration should take a different tact. We should not wipe out the default config.

Possibly a new option

overrideConfig: |
  Whatever random config you want

If overrideConfig is set use it and don't use the default at all.

My concern with these changes is you are breaking everyone and the default configuration for this chart is basically useless. Why don't we try and find a way to make both a reality.

[cdenneen]

@kimxogus when the bug for “null” works properly what issue will that not fix?

[kimxogus]

@sstarcher overrideConfig seems like a good solution :)
Added overrideConfig as suggested.

[sstarcher]

/ok-to-test

[kimxogus]

merged master

[kimxogus]

fixed conflicts. @sstarcher can you please review?

[sstarcher]

going to approve, but I believe it makes it easier to read if written
checksum/secret: {{ .Values.overrideConfig | default .Values.config | toYaml | sha256sum }}

[sstarcher]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimxogus, sstarcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/filebeat/OWNERS [sstarcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment