Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OCI metrics library a bit #8745

Merged
merged 1 commit into from May 15, 2024

Conversation

tjquinno
Copy link
Member

Description

This PR refactors how the OCI metrics library code is organized just a bit so other implementations can extend common types without having to also include the OCI metrics library CDI module (which is helpful if the other implementation has its own CDI work to do).

Documentation

No doc impact.

@tjquinno tjquinno self-assigned this May 10, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@tjquinno tjquinno requested a review from klustria May 13, 2024 12:09
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 774b5df into helidon-io:main May 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants