Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove references to requestpredicate #8579

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ljamen
Copy link
Contributor

@ljamen ljamen commented Mar 28, 2024

Description

Address #8333 @romain-grecourt I included your updated code snippet in the migration guide. The OP thought it was useful.

Documentation

If enhancement: provide description with example code/config snippet or pointer to issue with the description

If feature: summarize feature and provide pointer to doc issue

If no doc impact: None

@ljamen ljamen added the 4.x Version 4.x label Mar 28, 2024
@ljamen ljamen added this to Backlog in Helidon Doc via automation Mar 28, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 28, 2024
@ljamen ljamen removed this from Backlog in Helidon Doc Mar 28, 2024
@ljamen ljamen added the docs label Mar 28, 2024
So, for example, if you used the following in Helidon 3:

[source, java]
.Helidon 3.x using `RequestPredicate`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These snippets should go in src/main/java/io/helidon/docs/se/guides/Upgrade4xSnippets.java.
The 3.x snippet cannot be compiled and should be commented-out, you can see how it's done for the current snippets in that class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants