New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Fix Micronaut integration #8230
Open
jbescos
wants to merge
6
commits into
helidon-io:main
Choose a base branch
from
jbescos:issue7206_4x
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jan 12, 2024
romain-grecourt
changed the title
4.x: Fix Micronaut integration in Helidon 3.x? #7206
4.x: Fix Micronaut integration
Jan 12, 2024
There is one issue with validation: |
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos
force-pushed
the
issue7206_4x
branch
2 times, most recently
from
January 17, 2024 12:39
6cc1a8c
to
1351553
Compare
There are some unrelated tests failing under
I don't see Micronaut dependencies:
|
jbescos
force-pushed
the
issue7206_4x
branch
2 times, most recently
from
January 22, 2024 08:42
6aceb5d
to
a1ae08f
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@tomas-langer do we still need this change?. I think you said that when we have JPA changes integrated in Helidon we will not require this Micronaut upgrade. I guess we will remove Micronaut integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using Micronaut 4.x in Helidon 4.x: #7206
Documentation
N/A
A couple of comments:
helidon/integrations/micronaut/cdi-processor/src/main/java/module-info.java
because there was one issue with Micronaut modules having same packages. I opened an issue: the unnamed module reads package io.micronaut.inject.annotation from both io.micronaut.core_processor and io.micronaut.inject micronaut-projects/micronaut-core#10299 . Anyway, as we use this module for annotation processing there is no real need to have a module-info.