Update library.py #239
Open
Update library.py #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UNITS block set the scaling "factor", but was positioned below the XY block. So the XY block was using the default factor value of 1. Default GDS values lead to factor=0.001, and with this not being accounted for in each XY element, GDSs in microns were suddenly scaled up to mm.
|
I don't see how the block being moved inside the series of if/else clauses will have any impact. What matters is the order in which the data is stored in the GDSII file being loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNITS block set the scaling "factor", but was positioned below the XY block. So the XY block was using the default factor value of 1. Default GDS values lead to factor=0.001, and with this not being accounted for in each XY element, GDSs in microns were suddenly scaled up to mm.