Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic options to the runner #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steinybot
Copy link
Contributor

This is what I am using myself. I figured I may as well contribute it.

@@ -53,6 +53,7 @@ lazy val runner = Project(
).settings(standardSettings ++ bintrarySettings ++ Seq(
name := "hedgehog-runner"
) ++ Seq(libraryDependencies ++= Seq(
"com.github.scopt" %% "scopt" % "4.0.0-RC2"
Copy link
Collaborator

@charleso charleso Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you (again) for all the code contributions. I really appreciate it, and the time you've taken to do the work.

I'm really sorry to do this, but I'd very much like to keep hedgehog dependency free given (we've made it this far without scalaz/cats). Even if it means a bit of clunky/hacky pattern matching, I think it's worth that pain.

I'd be happy to help with that if you want a hand, I feel bad for making you do that extra work to make scala-hedgehog much nicer and more usable. :(

(EDIT: Other than that, it's great idea!!!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Just to double check before I invest the time, you would be ok with this change if I implement the option parsing without using a third-party library?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check before I invest the time, you would be ok with this change if I implement the option parsing without using a third-party library?

I would indeed!

For some background what I eventually want would be to add tag support and to be able to filter out tests that way (and to be able to reuse that arg parsing from SBT too).

Let me know if you need a hand. If I had the time I would probably write a micro opt-parse like module, but for 3 args at the moment you can probably do a simple pattern match and recurse. I'm sorry again to make you jump through that hoop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants