Show less context on failure

[sol]

Currently hedgehog error output is literally useless when used with hspec-hedgehog.

hedgehog includes the whole top-level definition in which the error occurred in the error output. Hspec test suites tend to define all tests in one top level definition. As a result, hspec-hedgehog will include the whole test suite in the error output for each failing test.

This produces lots of boring output with only little interesting output in between.

This PR allows the user to specify an upper limit of boring output lines that are printed around interesting output lines. This can be used by hspec-hedgehog to provide more useful error output.

hspec/hspec-hedgehog#35

[moodmosaic]

This looks good, and we could include it in the upcoming hedgehog 1.5 release 👍 🚀

I know it's a bit much to ask, but in respecting Jacob's memory, who was always using let instead of where, could we align with our style guidelines and make this adjustment? It’s a small tribute to his preferences and helps keep hedgehog codebase consistent too.

If you're not inclined to make this change, that's totally fine—I can take care of it before merging.

Thanks for your contribution, @sol!

[sol]

@moodmosaic thanks a lot for taking a look at this.

could we align with our style guidelines

That makes sense, yes 👍

I can take care of it before merging.

If it's not too much trouble for you then that would be great.

[sol]

I'm looking into it right now.

[sol]

@moodmosaic done! Anything else you need?

Changes:

https://github.com/hedgehogqa/haskell-hedgehog/compare/93d1f1e508970c27d2c872facdc26610d202743a..d92399b8bc4376a867c7400989322f94cef7487b

https://github.com/hedgehogqa/haskell-hedgehog/compare/ea5a0fe7dd527c85b3e701ed4e9d10955452d0ce..93d1f1e508970c27d2c872facdc26610d202743a

[moodmosaic]

LGTM!

[moodmosaic]

@sol, thank you 👍

In order to continue with hspec/hspec-hedgehog#35 do we want a new release on hackage?

[sol]

I'm gone use the git version for the time being. But once we have a release, all users will benefit from it, which I think will be a big improvement.

[moodmosaic]

Of course 👍 Let’s plan for a release in May.