Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build-depend on fail and semigroups with ancient GHC #323

Closed
wants to merge 1 commit into from

Conversation

clinty
Copy link

@clinty clinty commented Sep 14, 2019

No description provided.

@jacobstanley
Copy link
Member

Is this causing you a problem? fail and semigroups do that switch internally to make sure the right version is exported afaik

@clinty
Copy link
Author

clinty commented Sep 16, 2019

We don't have empty packages in Debian so any uses of them (fail, nats, bytestring-builder, etc.) need to be patched out which leads to a lot of wasted labor that needs to be repeated on every package upgrade. Things like semigroups are okay because they're not completely empty, but since you're not actually using Data.Semigroup.Generic there's no real point in including it either.

@moodmosaic
Copy link
Member

We don't have empty packages in Debian so any uses of them (fail, nats, bytestring-builder, etc.) need to be patched out

What's the current procedure for working around this issue? I don't have Debian around to try this, but both builds are green (just had to re-run the AppVeyor one).


If we decide to merge this, at least the dependencies should be aligned with all the others 🔎, like so:

image

image

@clinty
Copy link
Author

clinty commented Nov 14, 2019

Here's an example of how we work around fail in the repline package: https://sources.debian.org/src/haskell-repline/0.2.1.0-2/debian/patches/no-fail/

(cf. sdiehl/repline#14)

@jacobstanley jacobstanley force-pushed the master branch 2 times, most recently from 4139585 to c228279 Compare May 22, 2022 14:42
@sol
Copy link
Contributor

sol commented May 25, 2024

@moodmosaic from what I see in the current version of the Cabal file, I think this can be closed.

@moodmosaic
Copy link
Member

Thank you, @sol 🙌 Closing this, though @clinty absolutely feel free to re-open if needed. Thank you for your work on this. 👍

@moodmosaic moodmosaic closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants