Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom templates for charts #74

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

singerla
Copy link

Extract chart data from existing pptx files and use it as a template when creating a chart from scratch.

@singerla
Copy link
Author

singerla commented Mar 2, 2021

This PR also includes a fix for passing proper rId to chart. This allows creating multiple charts on a slide and/or mixed with images/links.

@heavysixer
Copy link
Owner

@singerla apologies for the late reply on this. First thanks for taking up this task and putting in the hard work here. @gregdolley there is a lot to consider here can we chat about this review?

@heavysixer
Copy link
Owner

@singerla apologies for the delay we're still discussing this internally.

@singerla
Copy link
Author

singerla commented Apr 6, 2021

@heavysixer don't worry, I can truly understand this PR isn't easy to handle :) You might want to at least cherry pick this, as it is required to insert multiple charts.

Please notice: The template based approach is perfect for my projects as they require a whole bunch of user defined settings. That's why I decided to start a template-only library: pptx-automizer.

I have learned many things here and I am thankful for the inspiration coming from your library! Keep on going!

@heavysixer
Copy link
Owner

@heavysixer don't worry, I can truly understand this PR isn't easy to handle :) You might want to at least cherry pick this, as it is required to insert multiple charts.

Please notice: The template based approach is perfect for my projects as they require a whole bunch of user defined settings. That's why I decided to start a template-only library: pptx-automizer.

I have learned many things here and I am thankful for the inspiration coming from your library! Keep on going!

@gregdolley let's please circle back around to this and resolve this one way or another.

@heavysixer
Copy link
Owner

@singerla as I am getting into your PR a bit more I think it's pretty clever how you support future chart types. I really like the fact that you can leverage charts in other files. One question do you think this approach will work for proprietary chart types like think-cell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants