1368 error fix #1369
Merged
1368 error fix #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that alterations in path for `replace_all` automatically expects multiple matches in a record. See: metafacture/metafacture-fix#249 Therefore I splitted the `replace_all` functions and created a function for each alteration.
dr0i
approved these changes
Aug 9, 2022
blackwinter
reviewed
Aug 10, 2022
| @@ -29,9 +29,12 @@ set_array("describedBy.type[]", "BibliographicDescription") | |||
| # <call-macro name="simplify-date" dname="dateModified" dsource="MNG .d"/> | |||
| copy_field("MNG .b","describedBy.dateCreated") | |||
| copy_field("MNG .d","describedBy.dateModified") | |||
| replace_all("describedBy.dateCreated|dateModified","-","") | |||
| replace_all("describedBy.dateCreated|dateModified"," .*","") | |||
| replace_all("describedBy.dateCreated|dateModified","c|©|\\s?|,|.|:|;|/|=","") | |||
There was a problem hiding this comment.
Any other potential bugs notwithstanding, I would strongly advise against relying on this wrong behaviour in the current Metafix implementation! See metafacture/metafacture-fix#143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was due to the buggy behavior that
replace_allwith alterations demands multiple matching path otherwise it breaks.See. metafacture/metafacture-fix#249
Fixes #1368.