Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation about Usage with graphql-scalars #919

Merged
merged 1 commit into from May 26, 2023

Conversation

arimgibson
Copy link
Sponsor Contributor

Closes #726.

Not sure if this is still relevant because of #910 but already had it 90% finished and kept forgetting to check formatting and PR... woops.

Anyway, feel free to play around with wording or whatever else if it's still relevant! Only concern is that the JSONResolver gets highlighted a little weirdly by highlight.js, but I'm not sure if there's a way to fix this.

image

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

⚠️ No Changeset found

Latest commit: ecdca37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pothos ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 3:47am

Copy link
Owner

@hayes hayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding this!

@hayes hayes merged commit bcc3c17 into hayes:main May 26, 2023
1 check passed
@hayes
Copy link
Owner

hayes commented May 26, 2023

Edited the wording a bit to be less opinionated, but overall love this change, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we use graphql-scalars scalars?
2 participants