Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 4.0 Branch #855

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

WIP 4.0 Branch #855

wants to merge 8 commits into from

Conversation

hayes
Copy link
Owner

@hayes hayes commented Mar 28, 2023

  • Refs should maintain types and have a reference to builder for chaining, mutation, and creating derivative types.
  • resolveType API should be redesigned to be more configurable
  • typing around interfaces should be made more flexible
  • relay plugin options should be made consistent with other options
  • validation plugin API needs to be re-visited
  • re-evaluate default type for ids
  • field refs should not be pre-assigned to a type so they can be re-used
  • Investigate return value authorization via isTypeOf checks
  • Unify/standardize/share loadOne/loadMany across plugins
  • Relay plugin should be update default nullability to match connection spec
  • Add typescript 4.7 variance hints to improve type-checking speed and responsiveness
  • Enable builder-independent refs for sharing type across packages
  • Standardize naming conventions for how plugin options are nested in builder options
  • Prisma connection total counts should be filtered by default
  • Consider alternative changeset versioning for linked packages
  • Brand all loaded nodes and make isTypeOf optional on node definitions
  • Bump min graphql to 16 and ts to ~4.7?
  • Support read-only tuples for list type references
  • Use consistent naming for plugin classes
  • disallow non-nullable t.relation fields for nullable relations [Prisma plugin] Non-nullable type should not be allowed with one-to-one relation #957
  • use const generic for enum values so you don't need to use as const in definitions

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: a797bdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pothos ❌ Failed (Inspect) Mar 15, 2024 2:35am

@hayes hayes changed the title Update default ID scalar type and add support for versioned defaults WIP 4.0 Branch Mar 28, 2023
@hayes hayes mentioned this pull request Jul 20, 2023
18 tasks
Update relay plugin default options

updated minimum graphql version

update plugin options to be more consistent

Add builder and SchemaTypes to field and type refs

Make relay connection edges nullable by default to match relay spec

Normalize plugin class names

fix linting for tests

Brand loaded objects by default

Add initial 4.0 migration guide

Add updated types and classes to migration guide

update plugin docs

Refactor refs so configs and fields are stored on refs

Make default field nullability true by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant