Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent executing connection resolver when only total count is selected #1025

Merged
merged 5 commits into from Sep 22, 2023
Merged

Prevent executing connection resolver when only total count is selected #1025

merged 5 commits into from Sep 22, 2023

Conversation

julioxavierr
Copy link
Contributor

Related to #989

@vercel
Copy link

vercel bot commented Sep 11, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pothos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 0:13am

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023 •
edited

⚠️ No Changeset found

Latest commit: 4b8a8f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@julioxavierr julioxavierr changed the title Prevent executing conneciton resolver when only total count is selected Prevent executing connection resolver when only total count is selected Sep 11, 2023
@julioxavierr julioxavierr marked this pull request as draft September 11, 2023 21:56
@julioxavierr julioxavierr marked this pull request as ready for review September 12, 2023 12:12
hayes
hayes reviewed Sep 14, 2023
View reviewed changes
Copy link
Owner

@hayes hayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! Sorry it's taken me a bit to getting around to reviewing it.

One thing that this doesn't cover is the total count on related connections. This isn't a blocker for this PR, but wanted to call out that might also need to be addressed before the issue is fully resolved

@hayes
Copy link
Owner

hayes commented Sep 22, 2023

Just pushed some changes that should address the remaining cases

@hayes hayes force-pushed the prisma-improve-total-count-load branch from 17c0135 to 4b8a8f7 Compare September 22, 2023 02:37
@hayes hayes merged commit 275f589 into hayes:main Sep 22, 2023
4 checks passed
@julioxavierr julioxavierr deleted the prisma-improve-total-count-load branch September 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayes hayes hayes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julioxavierr @hayes