Support Client Directives in Prisma plugin (@skip and @include) #1017
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1fc5b60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It would be great to add a test for these directives. The prisma tests all verify the queries that are executed, so adding a test that skips some relation field should be pretty straight forward |
| me { | ||
| id | ||
| name @skip(if: true) | ||
| email @include(if: false) |
There was a problem hiding this comment.
I think you need to add these to a relation instead to see any difference, unless you query a type that is using select mode. This change only changes the generated query, and not what revolvers get run.
query {
me {
id
profile @skip(if: true) {
bio
}
posts(limit: 1) @include(if: false) {
id
}There was a problem hiding this comment.
Thanks! I just updated the test
julioxavierr
force-pushed
the
prisma-support-client-directives
branch
from
bccfd8c
to
66a62ac
Compare
| @@ -65,6 +65,54 @@ describe('prisma', () => { | |||
| `); | |||
| }); | |||
|
|
|||
| it('skips fields based on @skip and @include directives', async () => { | |||
There was a problem hiding this comment.
sorry to keep asking for more changes one at a time, but would also be nice to check the inverted condition, so that if the conditions is reversed the selection includes the expected relations
There was a problem hiding this comment.
no worries! Just pushed one more commit
Related to #723