Toggling line wrap and readonly #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibilon
reviewed
May 23, 2017
haxe/ui/backend/ComponentBase.hx
Outdated
| window.destroy(); | ||
| window = replacement; | ||
|
|
||
| var platform:PlatformInfo = new PlatformInfo(); |
There was a problem hiding this comment.
It'd be better to factor out the common parts between replaceWindow and createWindow.
There was a problem hiding this comment.
Also, is this the correct way to go about it, you cant change wordwrap or readonly in wx at runtime on the same control?
There was a problem hiding this comment.
It depends on the plateform. According to the documentation it is possible to update the widget at runtime with wxGTK but not wxMSW. But even then, it still behave strangely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make possible to toggle the style for wrapping and editing by replacing the widget by a new one with required styles (#11).
Might require haxeui/haxeui-core#133