Added openshift templates with docker hub images #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gordillo-ramon-redhat , thanks for this PR. |
|
@gordillo-ramon-redhat I am not a fan of duplicating the templates as this PR does. Wouldn't it be easier / nicer to just separate the BC from the current template? i.e.:
|
|
Totally agree with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I think it is useful also to have templates with images already in docker repo (hub). So I have added these templates for setting up easier.
Please, can you add it to the repo?
I suggest to rename other openshift templates with "builder" suffix or so.
Thanks.