feat(repository): cache engine-relevant methods #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abelanger5
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Code looks good, only additional thing is the failing load test and integration test. We discussed the integration test and making the expiry configurable.
Looks like the load test is failing with:
cli_e2e_test.go:81: found unexpected goroutines:
[Goroutine 41 in state select, with github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...].func1 on top of the stack:
github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...].func1()
/home/runner/go/pkg/mod/github.com/hashicorp/golang-lru/v2@v2.0.7/expirable/expirable_lru.go:86 +0x1d1
created by github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...] in goroutine 7
/home/runner/go/pkg/mod/github.com/hashicorp/golang-lru/v2@v2.0.7/expirable/expirable_lru.go:82 +0x57d
Goroutine 99 in state select, with github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...].func1 on top of the stack:
github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...].func1()
/home/runner/go/pkg/mod/github.com/hashicorp/golang-lru/v2@v2.0.7/expirable/expirable_lru.go:86 +0x1d1
created by github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...] in goroutine 67
/home/runner/go/pkg/mod/github.com/hashicorp/golang-lru/v2@v2.0.7/expirable/expirable_lru.go:82 +0x57d
]
steebchen
force-pushed
the
feat/repository-cache
branch
from
a7a7995
to
d5b231a
Compare
steebchen
force-pushed
the
feat/repository-cache
branch
from
673d57f
to
6946884
Compare
steebchen
force-pushed
the
feat/repository-cache
branch
from
24764c3
to
ea898c7
Compare
steebchen
force-pushed
the
feat/repository-cache
branch
from
ea898c7
to
fa3166e
Compare
abelanger5
approved these changes
Mar 21, 2024
|
|
||
| // Get retrieves the value associated with the given key from the cache. | ||
| func (c *TTLCache[K, V]) Get(key K) (V, bool) { | ||
| c.mu.Lock() |
There was a problem hiding this comment.
Would be good to add a benchmark test to see how many Gets/second we can handle. Don't imagine this will be a bottleneck anytime soon but would still be good to have a sense.
There was a problem hiding this comment.
right, tracked via #282
* feat(repository): cache engine-relevant methods * feat(repository): use generic cacheable function * improvements * undo skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
What's Changed