Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): fix typo in Schema.hs #9702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eltociear
Copy link

@eltociear eltociear commented Jun 7, 2023

Description

Fix a misspelled word in a comment: additionaly -> additionally

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

additionaly -> additionally
@eltociear eltociear requested a review from a team as a code owner June 7, 2023 12:52
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @eltociear, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm spelling is fixed

Comment on lines 4 to +6
-- * The /catalog/ refers to the set of PostgreSQL tables and views that store all schema information
-- known by Hasura. This includes any tracked Postgres tables, views, and functions, all remote
-- schemas, and any additionaly Hasura-specific information such as permissions and relationships.
-- schemas, and any additionally Hasura-specific information such as permissions and relationships.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, shouldn't it say and any additional Hasura-specific information?

@abooij
Copy link
Contributor

abooij commented Jun 8, 2023

@hallettj FYI, to add this PR to the merge queue, you have to approve the corresponding PR on the mono repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants