Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add left/right element #9696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukaselmer
Copy link

Description

Adds a component and an example to split a section into a left and right side. I don't think that this is an improvement the way it is, but it may be the start of a potential solution.

Solution and Design

image

http://localhost:3000/docs/latest/api-reference/graphql-api/mutation/

Limitations, known bugs & workarounds

Since both the right and left contents are too wide and would require scrolling, I consider this new solution worse, compared to how it is currently implemented.

If this new solution is to be considered, the contents of the document would need to span over the two red boxes in the screenshot below, so that less space is lost on the screen:

how it is at the moment:

image

hacked together how it would make more sense to me (but probably brings other issues / doesn't make sense on every page):

image

Note: The 300px in LeftRight is certainly not large enough, and only so small to demonstrate an example. The side-by side view should only be available if the screen is very wide IMHO.

@lukaselmer lukaselmer requested a review from a team as a code owner June 5, 2023 21:17
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @lukaselmer, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants