-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul Nix Infrastructure #700
base: master
Are you sure you want to change the base?
Conversation
Waiting on NixOS/nixpkgs#306749 to be merged for torch 2.3 support. |
@collinarnett libtorch 2.3 of nixpkgs is available. |
OK I'll work on getting this compatible ASAP. |
Now all packages build with |
Very fantastic to see everything using vanilla nix. So many lines of custom nix code removed ! I'm eagerly awaiting the merge of this great PR. Looks like its basically complete right ? P.S. I looked at this in more detail -- this is still missing ability to |
Yes from a functional perspective it's pretty much finished. You can try it out by using my branch as a flake input and then adding the overlay to your flake.
At the moment the priority is distributing hasktorch but since this PR uses the default nix haskell infra it's probably safe to assume making a development shell is a simple as using shellFor with the outputs from the overlay. Either way, I plan on updating https://github.com/collinarnett/hasktorch-skeleton this weekend to give people a demo project of how hasktorch is used as well as packaging the tests to finish up this PR. |
@sidkshatriya I've gone ahead and updated hasktorch-skeleton. So go ahead and play around with it and let me know if you have any feedback. It may take a while to compile all the needed packages but once everything is tested a bit more, I'll figure out how to update the CI to get cachix setup. |
This PR removes the dependecy on haskell.nix and instead relies on the vanilla haskell infrastructure for nix. The primary means of exporting hasktorch will now be an overlay.
Merge Criteria: