Bug fix for space leak on too frequent calls to performGC #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +25,15 @@ newtype OptimizerState option = OptimizerState option | |||
| grad' :: Loss -> [Parameter] -> Gradients | |||
| grad' t p = Gradients (grad t p) | |||
|
|
|||
| -- | Action that performs garbage collection with a minimum waiting time between calls to `performGC`. This prevents a space leak, that occurs when calling `performGC` too frequently. | |||
| performGC' :: IO () | |||
| performGC' = unsafePerformIO $ do | |||
There was a problem hiding this comment.
I think unsafePerformIO should not be added.
It may disappear these codes.
|
@schnecki Thank you for your contribution! Do you have any benchmarks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://gitlab.haskell.org/ghc/ghc/-/issues/18239
possibly related #452
see also #453