Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nms for a motivational example of Record Dot Syntax #630

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add nms for a motivational example of Record Dot Syntax #630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa7343e
Add nms for motivational example of Record Dot Syntax
junjihashimoto Dec 9, 2021
d59d6e1
Add generic nms with HasField
junjihashimoto Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
97 changes: 97 additions & 0 deletions hasktorch/src/Torch/Typed/Vision.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,100 @@ initMnist path = do
testImagesBS <- decompressFile path "t10k-images-idx3-ubyte.gz"
testLabelsBS <- decompressFile path "t10k-labels-idx1-ubyte.gz"
return (MnistData imagesBS labelsBS, MnistData testImagesBS testLabelsBS)

data Box a = Box
{ x1 :: a,
y1 :: a,
x2 :: a,
y2 :: a,
score :: a
}
deriving (Show, Eq, Generic, Default)

nmsCpu :: Num a => [Box a] -> a -> [Box a]
nmsCpu dets = nms_cpu' (sortBy score dets)
where
nms_cpu' :: Num a => [Box a] -> a -> [Box a]
nms_cpu' [] _ = []
nms_cpu' (head_:tail_) iou_threshold = head_: nms_cpu filtered_boxes iou_threshold
where
head_area = (x2 head_ - x1 head_) * (y2 head_ - y1 head_)
filtered_boxes = filter (\v ->
let
xx1 = max (x1 head_) (x1 v)
yy1 = max (y1 head_) (y1 v)
xx2 = min (x2 head_) (x2 v)
yy1 = min (y2 head_) (y2 v)
v_area = (xx2 - xx1) * (yy2 - yy1)
inter_area = (xx2 - xx1) * (yy2 - yy1)
iou = inter_area / (head_area + v_area - inter_area)
in iou < iou_threshold
) tail_

-- THe reference code of nms
-- https://github.com/rbgirshick/fast-rcnn/blob/master/lib/utils/nms.py

nms :: NamedTensor device dtype '[Vector n, Box] -> Float -> NamedTensor device dtype '[Vector m, Box]
nms dets iou_threshold = dets ! (loop sort_idxes 0)
where
sort_idxes = sortNamedDim @"score" dets
areas =
(dets ^. field @"x2" - dets ^. field @"x1") *
(dets ^. field @"y2" - dets ^. field @"y1")
loop sort_idxes i | length sort_idxes <= i = sort_idxes
| otherwise =
let
idx = sort_idxes ! i
other_idxes = sort_idxes ! [slice|({i}+1):|]
xx1 = max (dets ! idx ^.field@"x1") ((dets ! other_idxes) ^. field @"x1")
xx2 = min (dets ! idx ^.field@"x2") ((dets ! other_idxes) ^. field @"x2")
yy1 = max (dets ! idx ^.field@"y1") ((dets ! other_idxes) ^. field @"y1")
yy2 = min (dets ! idx ^.field@"y2") ((dets ! other_idxes) ^. field @"y2")
inter_areas = (xx2 - xx1) * (yy2 - yy1)
iou = inter_areas / ((area ! idx) + (areas ! other_idxes) - inter_areas)
in loop (delete sort_idxes (iou >= iou_threshold)) (i+1)

nmsWithDotsyntax :: NamedTensor device dtype '[Vector n, Box] -> Float -> NamedTensor device dtype '[Vector m, Box]
nmsWithDotsyntax dets iou_threshold = dets ! (loop sort_idxes 0)
where
sort_idxes = sortNamedDim @"score" dets
areas =
(dets.x2 - dets.x1) *
(dets.y2 - dets.y1)
loop sort_idxes i | length sort_idxes <= i = sort_idxes
| otherwise =
let
idx = sort_idxes ! i
other_idxes = sort_idxes ! [slice|({i}+1):|]
xx1 = max (dets ! i).x1 (dets ! other_idxes).x1
xx2 = min (dets ! i).x2 (dets ! other_idxes).x2
yy1 = max (dets ! i).y1 (dets ! other_idxes).y1
yy2 = min (dets ! i).y2 (dets ! other_idxes).y2
inter_areas = (xx2 - xx1) * (yy2 - yy1)
iou = inter_areas / ((area ! idx) + (areas ! other_idxes) - inter_areas)
in loop (delete sort_idxes (iou >= iou_threshold)) (i+1)

genericNms :: ( HasField "x1" a
, HasField "x2" a
, HasField "y1" a
, HasField "y2" a
, HasField "score" a
) => NamedTensor device dtype '[Vector n, a] -> Float -> NamedTensor device dtype '[Vector m, a]
genericNms dets iou_threshold = dets ! (loop sort_idxes 0)
where
sort_idxes = sortNamedDim @"score" dets
areas =
(dets.x2 - dets.x1) *
(dets.y2 - dets.y1)
loop sort_idxes i | length sort_idxes <= i = sort_idxes
| otherwise =
let
idx = sort_idxes ! i
other_idxes = sort_idxes ! [slice|({i}+1):|]
xx1 = max (dets ! i).x1 (dets ! other_idxes).x1
xx2 = min (dets ! i).x2 (dets ! other_idxes).x2
yy1 = max (dets ! i).y1 (dets ! other_idxes).y1
yy2 = min (dets ! i).y2 (dets ! other_idxes).y2
inter_areas = (xx2 - xx1) * (yy2 - yy1)
iou = inter_areas / ((area ! idx) + (areas ! other_idxes) - inter_areas)
in loop (delete sort_idxes (iou >= iou_threshold)) (i+1)