Enable profile by default

[junjihashimoto]

hasktorch is development phase, so we are going to take profile many times.
This pr enables profile by default.

[tscholak]

LGTM! actually, I've spotted a problem

[tscholak]

Hi @junjihashimoto, your last commit, b725b9f, only added the enableLibraryProfiling to the scope, but you still have to use it.

[tscholak]

for instance, instead of

                    "hasktorch_${postfix}" =
                      overrideCabal
                        (haskellPackagesOld.callCabal2nix
                          "hasktorch"
                          ../hasktorch
                          { libtorch-ffi = haskellPackagesNew."libtorch-ffi_${postfix}"; }
                        )
                        (old: {
                              preConfigure = (old.preConfigure or "") + optionalString (!isDarwin) ''
                                export LD_PRELOAD=${pkgs.mkl}/lib/libmkl_rt.so
                              '';
                            }
                        );

write

                    "hasktorch_${postfix}" =
                      enableLibraryProfiling
                        (overrideCabal
                          (haskellPackagesOld.callCabal2nix
                            "hasktorch"
                            ../hasktorch
                            { libtorch-ffi = haskellPackagesNew."libtorch-ffi_${postfix}"; }
                          )
                          (old: {
                                preConfigure = (old.preConfigure or "") + optionalString (!isDarwin) ''
                                  export LD_PRELOAD=${pkgs.mkl}/lib/libmkl_rt.so
                                '';
                              }
                          )
                        );

[junjihashimoto]

@tscholak
Thank you for pointing it out.

BTW, the failure of CI on stack-macos is the same as this issue(fpco/inline-c#102).

[tscholak]

@junjihashimoto, in order to fix this nasty macOS bug, I introduced this hot-fix:

hasktorch/nix/shared.nix

Lines 46 to 48 in b725b9f

	preConfigure = (old.preConfigure or "") + optionalString isDarwin ''
	sed -i -e 's/-optc-std=c++11 -optc-xc++/-optc-xc++/g' ../libtorch-ffi/libtorch-ffi.cabal;
	'';

I'm surprised it's not working any longer

[tscholak]

@junjihashimoto it’s super hard to make both cabal and stack happy about this cx flag on all platforms. That’s why I went for this hot-fix solution in shared.nix

[junjihashimoto]

@tscholak
I can not find options to pass stack-macos.
This commit(0480dab) is the same as nix's one. But stack fails.

[junjihashimoto]

@tscholak
I've realized setting profile on macos is super hard.
ghc passes options of "-DPROFILING -x c" to clang in front of user's options(-xc++ -std=c++11).
clang uses the option of "clang -xc++ -std=c++11 -DPROFILING -x c 'generated code'."
So clang recognizes generated codes of inline-c-cpp as c-sources.
I am finding the source-codes adding the options in ghc-repo.

[junjihashimoto]

We can get the result of benchmark from artifact of github-action.

[tscholak]

sweet, @junjihashimoto !

[tscholak]

I can try to fix the nix-macos build later today if it should still fail

[junjihashimoto]

nix-macos fails during setup of nix.
I share the error with cachix-action.
https://github.com/cachix/cachix-action/issues/14

[tscholak]

O.o, ok. I'll follow this one.