Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic thread support #126

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

pmacg
Copy link

@pmacg pmacg commented Aug 29, 2019

This change adds some very basic thread support to the application:

  • If a message in a channel has replies, show the number of messages in the thread
  • Pressing 't' on a particular message shows a thread view with just the messages in the thread
  • Pressing 't' on a message in a thread returns to the channel
  • Posting a message while viewing a thread will post the message in the thread rather than in the channel

Resolves Issue #125 .

@pmacg
Copy link
Author

pmacg commented Aug 30, 2019

Actually addresses #105

@pmacg pmacg mentioned this pull request Aug 30, 2019
@k4ml
Copy link

k4ml commented Oct 10, 2019

Seem to work so far. This PR prevent me from going away ;)

@mitas
Copy link

mitas commented Oct 10, 2019

@k4ml me too

@icyJoseph
Copy link

@pmacg I too vouch for this PR, seems to work swell. @haskellcamargo any comments?

@haskellcamargo
Copy link
Owner

I'm gonna take a look on this PR tomorrow! I'm excited for thread support as well.

@jtagcat
Copy link

jtagcat commented Apr 19, 2020

It is April, Slack has rolled out it's new slower than ever UI. I can see the last word being typed while typing the next word. Any updates?

@ubuntudroid
Copy link

Is this still being worked on?

@pmacg
Copy link
Author

pmacg commented Oct 6, 2020

Is this still being worked on?

I'm not still working on it and I actually no longer use slack, so I won't know if it breaks!

The PR is just waiting for approval from @haskellcamargo

@james-see
Copy link

@haskellcamargo anything? can we merge if it works?

@duynguyenhoang
Copy link
Collaborator

Thank you for this effort, I will test and merge it ASAP. Sorry I am quite busy recently and unable to check all PRs

@jotech
Copy link

jotech commented Nov 23, 2020

any updates on this? I checked the pull request locally and it seems to work with base branch!

@satelliteoflove
Copy link

@duynguyenhoang do you have any updates on this? Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet