Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) #658

jneira · 2020-12-09T07:30:49Z

This will not be the final commit (ghcide has to be released yet) but let's see what has to say ci.

alanz

Happy with this, once CI passes

Ailrun · 2020-12-09T09:46:13Z

Awesome! CI says there is an ambiguity for findCradle, but that's a minor problem.

jneira · 2020-12-09T13:19:08Z

stack build in circleci using stack-8.8.3.yaml and stack-8.8.2.yaml (but no for stack-8.8.4.yaml) is failing with

Progress 166/173: ghcide ghcide > /root/build/ghcide/src/Development/IDE/Plugin/Completions/Logic.hs:267:5: error:
Progress 166/173: ghcide ghcide >     • Illegal equational constraint NoGhcTcPass pass
Progress 166/173: ghcide ghcide >                                     ~ NoGhcTcPass (NoGhcTcPass pass)
Progress 166/173: ghcide ghcide >       (Use GADTs or TypeFamilies to permit this)
Progress 166/173: ghcide ghcide >     • When checking the inferred type
Progress 166/173: ghcide ghcide >         f :: forall (pass :: Pass).
Progress 166/173: ghcide ghcide >              (Outputable.OutputableBndr
Progress 166/173: ghcide ghcide >                 (NameOrRdrName (IdP (GhcPass (NoGhcTcPass pass)))),
Progress 166/173: ghcide ghcide >               Outputable.OutputableBndr (IdP (GhcPass (NoGhcTcPass pass))),
Progress 166/173: ghcide ghcide >               Outputable.OutputableBndr (IdP (GhcPass pass)),
Progress 166/173: ghcide ghcide >               Outputable.OutputableBndr (NameOrRdrName (IdP (GhcPass pass))),
Progress 166/173: ghcide ghcide >               Outputable (XIPBinds (GhcPass pass)),
Progress 166/173: ghcide ghcide >               Outputable (XViaStrategy (GhcPass pass)),
Progress 166/173: ghcide ghcide >               Outputable (XIPBinds (GhcPass (NoGhcTcPass pass))),
Progress 166/173: ghcide ghcide >               Outputable (XViaStrategy (GhcPass (NoGhcTcPass pass))),
Progress 166/173: ghcide ghcide >               NoGhcTcPass pass ~ NoGhcTcPass (NoGhcTcPass pass)) =>
Progress 166/173: ghcide ghcide >              Maybe Range -> ImportDecl (GhcPass pass) -> Maybe [TextEdit]
Progress 166/173: ghcide ghcide >       In the expression:
Progress 166/173: ghcide ghcide >         let
Progress 166/173: ghcide ghcide >           f (Just range) ImportDecl {ideclHiding}
Progress 166/173: ghcide ghcide >             = case ideclHiding of
Progress 166/173: ghcide ghcide >                 Just (False, x)
Progress 166/173: ghcide ghcide >                   | Set.notMember name (Set.fromList ...) -> ...
Progress 166/173: ghcide ghcide >                   | otherwise -> ...
Progress 166/173: ghcide ghcide >                 _ -> ...
Progress 166/173: ghcide ghcide >           f _ _ = Nothing
Progress 166/173: ghcide ghcide >           src_span = srcSpanToRange . getLoc $ lDecl
Progress 166/173: ghcide ghcide >         in f src_span . unLoc $ lDecl
Progress 166/173: ghcide ghcide >       In an equation for ‘extendImportList’:
Progress 166/173: ghcide ghcide >           extendImportList name lDecl
Progress 166/173: ghcide ghcide >             = let
Progress 166/173: ghcide ghcide >                 f (Just range) ImportDecl {ideclHiding} = ...
Progress 166/173: ghcide ghcide >                 f _ _ = Nothing
Progress 166/173: ghcide ghcide >                 src_span = srcSpanToRange . getLoc $ lDecl
Progress 166/173: ghcide ghcide >               in f src_span . unLoc $ lDecl
Progress 166/173: ghcide ghcide >     |
Progress 166/173: ghcide ghcide > 267 |     f (Just range) ImportDecl {ideclHiding} = case ideclHiding of
Progress 166/173: ghcide ghcide >     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...
Progress 166/173: ghcide ghcide >

As ghcide is not being built with ghc-8.8.3 or ghc-8.8.2 we dont get direct evidence if this error would be reproduced building ghcide standalone 🤔

stack-8.6.5.yaml and stack-8.6.4.yaml had built ghcide succesfully though.

EDIT: github test builds with cabal and ghc-8.8.3 and ghc-8.8.2 has failed with the same error

jneira · 2020-12-09T13:20:41Z

I've leveraged the new findCradle from the new ghcide session options and replacing hie-bios one with 03bd6d8

jneira · 2020-12-09T13:25:08Z

Some of nix builds (default, ghc8102) in github are failing with

 building '/nix/store/5iw4gkavrvbyk9kqmfzbrr0mslyd39xa-cabal2nix-haskell-language-server.drv'...
installing
building '/nix/store/z6136irqnsp2qjwdics1aix0y0l0hmc2-cabal2nix-ghcide.drv'...
installing
error: anonymous function at /nix/store/fysbydywdhlim0yl5djdk4nm07402v96-cabal2nix-ghcide/default.nix:1:1 called without required argument 'shake-bench', at /nix/store/51gm3gjl7i2n3f7pamrbsckm4h0fmhy2-nixpkgs-src/pkgs/development/haskell-modules/make-package-set.nix:87:27
(use '--show-trace' to show detailed location information)
Error: Process completed with exit code 1.

I guess we have to change nix config files but i dont know how

pepeiborra · 2020-12-09T15:01:19Z

shake-bench is a new local package in the ghcide repo. It needs to be added in nix/default.nix.

Does the comment at the top of shell.nix help?

haskell-language-server/shell.nix

Lines 4 to 10 in 9120f4b

    
           # Maintaining this file: 
        
           # 
        
           #     - Bump the nixpkgs version using `niv update nixpkgs` 
        
           #     - To edit the set of local packages: 
        
           #       1. Declare them in nix/default.nix 
        
           #       2. Edit the list of packages below 
        
           #

jneira · 2020-12-09T16:45:59Z

@pepeiborra yeah, I missed that config file, only took a quick look inside the nix dir

jneira · 2020-12-10T07:12:03Z

Ok, two issues blocks the pr now:

builds for ghc-8.8.2 and 8.8.3 don't compile due to Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) #658 (comment)
the recently enabled completion tests thanks to @peterwicksstringfield are failing with timeouts
- But they are succesful with actual version of ghcide so the bump has broken them

@pepeiborra what do you think about add GADT's to the ghcide module to check if it fixes the issue and use that commit in hls? Ideally that version should be the last released one in hackage

@peterwicksstringfield could you take a quick look to completion tetsts to see if they can be fixed without too much effort?
I am afraid that maybe we will need to mark them as broken again temporary to unblock the release. Assuming that features continue working.

alanz · 2020-12-10T08:28:41Z

I am wondering if the corners being cut in ghcide CI are worth it.

pepeiborra · 2020-12-10T08:30:38Z

I am wondering if the corners being cut in ghcide CI are worth it.

Not related. We have cut some stack jobs, but we never had builds for 8.8.2 and 8.8.3. And yes, they are worth it.

pepeiborra · 2020-12-10T08:31:59Z

builds for ghc-8.8.2 and 8.8.3 don't compile due to #658 (comment)
@pepeiborra what do you think about add GADT's to the ghcide module to check if it fixes the issue and use that commit in hls? Ideally that version should be the last released one in hackage

We will have to add 8.8.2 and 8.8.3 to the test matrix in ghcide CI. I'll see to that.

jneira · 2020-12-10T08:40:18Z

We will have to add 8.8.2 and 8.8.3 to the test matrix in ghcide CI. I'll see to that.

Many thanks, ideally ghcide should have the same matrix than hls, at least with cabal. So maybe we should add ghc-8.6.4 and ghc-8.10.1 too as they are missing in ghcide afair.

jneira · 2020-12-10T10:33:25Z

fix building with ghc-8.8.3 and ghc-8.8.2 in Use GADTs for all ghc versions in Development.IDE.Plugin.Completions.Logic ghcide#947
@pepeiborra ci pr adding missing ghc versions with Extend CI matrix with all the GHC minor versions supported by HLS ghcide#946

peterwicksstringfield · 2020-12-12T22:15:58Z

I have no objections to re-disabling these tests for now.

In #668 I am attempting to fix the tests.

peterwicksstringfield · 2020-12-13T19:03:24Z

You might have already seen it, but the failure on (ci/circleci: ghc-8.8.2) is something about a dependency on apply-refact.

jneira · 2020-12-14T06:58:34Z

Not sure why brittany and floskell have changed at once the order of imports from

import           Data.List
import           Prelude
import           Data.Int

to

import           Data.List
import           Data.Int
import           Prelude

but it seems the actual behaviour is right iirc so i've updated the golden files.

jneira · 2020-12-14T07:18:04Z

Nix is failing now with

Error: Action failed with error: Error: The process '/nix/var/nix/profiles/per-user/runner/profile/bin/cachix' failed with exit code 1
  (node:3080) UnhandledPromiseRejectionWarning: Error: The process '/nix/var/nix/profiles/per-user/runner/profile/bin/cachix' failed with exit code 1
      at ExecState._setResult (/home/runner/work/_actions/cachix/cachix-action/v8/dist/main/index.js:907:25)
      at ExecState.CheckComplete (/home/runner/work/_actions/cachix/cachix-action/v8/dist/main/index.js:890:18)
      at ChildProcess.<anonymous> (/home/runner/work/_actions/cachix/cachix-action/v8/dist/main/index.js:790:27)
      at ChildProcess.emit (events.js:210:5)
      at maybeClose (internal/child_process.js:1021:16)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
  (node:3080) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
  (node:3080) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I hope it is a transient one

jneira · 2020-12-14T07:57:36Z

I think #672 should be the last pr to be merged before cut the release version so please, dont merge additional pr's to master until the tag is created (if you think someone else should be included comment it out here or in the pr itself)

jneira · 2020-12-14T11:25:31Z

Waiting for ci... 🙄

completion/Context.hs used to generate a diagnostic for the unused "x", but no longer does so without -Wunused-binds. completion/Completion.hs used to generate a diagnostic for the unused import of Data.Maybe, but no longer does so without -Wunused-imports. We could add these flags like: {-# OPTIONS_GHC -Wunused-binds #-} But that would force us to update all the hardcoded line numbers in the unit tests. Instead we just add a redundant id, carefully positioned to avoid disturbing any hardcoded positions.

…n ghcide 6.0.

Snippets are back in ghcide 0.6.0.

… it.

Stop messing around the editing the file and reloading it. We are trying to test code completion, not editing files, and the extra complexity is making it harder to maintain the test.

jneira · 2020-12-14T21:14:12Z

Hosted macOS workflows will experience longer wait times the week of December 14th.

actions/runner-images#2247

jneira requested review from pepeiborra and alanz December 9, 2020 07:30

alanz approved these changes Dec 9, 2020

View reviewed changes

jneira force-pushed the ghcide-0.6 branch from 3e0da1f to 9ef6cbd Compare December 9, 2020 22:11

jneira mentioned this pull request Dec 10, 2020

Use GADTs for all ghc versions in Development.IDE.Plugin.Completions.Logic haskell/ghcide#947

Merged

peterwicksstringfield mentioned this pull request Dec 12, 2020

Pr 658 fix completion tests #668

Closed

pepeiborra approved these changes Dec 13, 2020

View reviewed changes

jneira force-pushed the ghcide-0.6 branch from 3fb2a73 to 9bb3cb2 Compare December 13, 2020 13:19

jneira force-pushed the ghcide-0.6 branch from 9bb3cb2 to cbf1c37 Compare December 13, 2020 20:43

jneira changed the title ~~Bump ghcide to incoming 0.6~~ Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) Dec 14, 2020

jneira force-pushed the ghcide-0.6 branch from 14bd93c to e61afcc Compare December 14, 2020 08:04

Bump ghcide to incoming 0.6

8416433

jneira and others added 24 commits December 14, 2020 19:58

Update hackage index to 2020-12-09T06:57:58Z

f70d5ba

Bump up ghcide lower bound to 0.6

4696e0e

Update stack config to use ghcide-0.6

00db351

Use definitive ghcide-0.6

9caea6f

Leverage new ghcide loading options

3c7143d

Add shake-bench component to nix build

16e8e89

Use brittany version compat with ghc-8.10

ea14692

Use ghcide version fixed for ghc-8.x

4457ef5

Update completion tests to reflect the renewed support for snippets i…

c807d44

…n ghcide 6.0.

Enable disabled tests for the code completion snippets.

7fad57c

Snippets are back in ghcide 0.6.0.

Disable test for completionSnippetsOn option, ghcide does not support…

20cef9e

… it.

Fix test for code completion of qualified name.

56629b1

Stop messing around the editing the file and reloading it. We are trying to test code completion, not editing files, and the extra complexity is making it harder to maintain the test.

Ensure that the testfiles produce at least one diagnostic.

3e6378a

Use brittany last released version

4d52537

Use ghcide-0.6.0.1

10fb877

Add apply-refact to stack-8.8.2.yaml

0e250a4

Replacing waitForDiagnostics with sleep

7135541

Adapt brittany golden test

be6db04

Adapt floskell golden test

94f8095

Adapt brittany+floskell golden test

cd17a0a

Ensure ghcide-0.6.0.1 in cabal config

4766074

Update ChangeLog with 0.7 changes

4a58f1f

Bump package versions

ac99654

jneira force-pushed the ghcide-0.6 branch from aaa9f2f to ac99654 Compare December 14, 2020 18:59

Ailrun approved these changes Dec 15, 2020

View reviewed changes

jneira merged commit 6a692de into haskell:master Dec 15, 2020

jneira deleted the ghcide-0.6 branch January 15, 2021 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) #658

Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) #658

jneira commented Dec 9, 2020 •

edited

alanz left a comment

Ailrun commented Dec 9, 2020

jneira commented Dec 9, 2020 •

edited

jneira commented Dec 9, 2020

jneira commented Dec 9, 2020 •

edited

pepeiborra commented Dec 9, 2020 •

edited

jneira commented Dec 9, 2020

jneira commented Dec 10, 2020 •

edited

alanz commented Dec 10, 2020

pepeiborra commented Dec 10, 2020 •

edited

pepeiborra commented Dec 10, 2020 •

edited

jneira commented Dec 10, 2020

jneira commented Dec 10, 2020

peterwicksstringfield commented Dec 12, 2020

peterwicksstringfield commented Dec 13, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) #658

Prepare 0.7.0 release (includes bump ghcide to 0.6.0.1) #658

Conversation

jneira commented Dec 9, 2020 • edited

alanz left a comment

Choose a reason for hiding this comment

Ailrun commented Dec 9, 2020

jneira commented Dec 9, 2020 • edited

jneira commented Dec 9, 2020

jneira commented Dec 9, 2020 • edited

pepeiborra commented Dec 9, 2020 • edited

jneira commented Dec 9, 2020

jneira commented Dec 10, 2020 • edited

alanz commented Dec 10, 2020

pepeiborra commented Dec 10, 2020 • edited

pepeiborra commented Dec 10, 2020 • edited

jneira commented Dec 10, 2020

jneira commented Dec 10, 2020

peterwicksstringfield commented Dec 12, 2020

peterwicksstringfield commented Dec 13, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 14, 2020

jneira commented Dec 9, 2020 •

edited

jneira commented Dec 9, 2020 •

edited

jneira commented Dec 9, 2020 •

edited

pepeiborra commented Dec 9, 2020 •

edited

jneira commented Dec 10, 2020 •

edited

pepeiborra commented Dec 10, 2020 •

edited

pepeiborra commented Dec 10, 2020 •

edited