Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enable pedantic for each cabal package separately #4223

Closed
wants to merge 1 commit into from

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented May 12, 2024

It seems that the original "all +pedantic" doesn't enable pedantic flag for everything
If you run cabal configure --constraint "all +pedantic" followed by

cabal build -v2   #among other things verbosity level 2 outputs "Flags chosen: ... pedantic=False... " for each target
# or 
cabal build -v2 all
# or 
cabal build -v2 <specific-component>

you' won't see any pedantic=True anywhere.
Doing it on per-cabal-file basis seems to work fine (and leads to desirable CI failures).

@jhrcek jhrcek marked this pull request as ready for review May 12, 2024 11:36
@jhrcek jhrcek marked this pull request as draft May 12, 2024 11:37
@michaelpj
Copy link
Collaborator

Baffling.

@jhrcek
Copy link
Collaborator Author

jhrcek commented May 17, 2024

Closing this for now as I enabled pedantic for most subprojects in #4224
Will work towards fixing all warnings in ghcide in separate PR.

@jhrcek jhrcek closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants