hls-cabal-plugin: refactor context search to use readFields
#4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
enhance/cabal-readfields
branch
from
9060700
to
16a201c
Compare
fendor
changed the title
readFieldsreadFields
fendor
force-pushed
the
enhance/cabal-readfields
branch
from
16a201c
to
46ad7dd
Compare
fendor
force-pushed
the
enhance/cabal-readfields
branch
from
46ad7dd
to
b5587a8
Compare
VeryMilkyJoe
force-pushed
the
enhance/cabal-readfields
branch
from
b5587a8
to
02f3bf9
Compare
fendor
force-pushed
the
enhance/cabal-readfields
branch
3 times, most recently
from
ad60fbb
to
818e6ee
Compare
fendor
force-pushed
the
enhance/cabal-readfields
branch
5 times, most recently
from
c5711f4
to
6d9778e
Compare
soulomoon
approved these changes
May 28, 2024
|
Why is the test not running |
|
Hm, I am also confused. Perhaps all my force pushing messed up the CI :) |
|
Will it help with #3333 |
|
No, this tries to fix some bugs in the cabal file completions that I encountered while dogfooding the plugin. This does not affect the tests at all. The tests are flaky, for the same reason hlint tests are/were flaky, afaict. |
fendor
force-pushed
the
enhance/cabal-readfields
branch
from
6d9778e
to
5f70b19
Compare
Add utils that allows to define parameterised tests for files that require cursor positions. This enables us to define run the same tests for multiple inputs efficiently, and with readable error messages. The main advantage is the improved specification of the test cases, as we allow to specify the cursor position directly in the source of the test files.
Instead of custom parsing of the cabal file, we use `readFields` to parse the cabal file, as accurately as cabal supports. This allows us to additionally benefit from future improvements to the cabal lexer. Then, we traverse the fields and find the most likely location of the cursor in the cabal file. Based on these results, we can then establish the context accurately. Further, we extend the known rules for the cabal plugin, to avoid expensive reparsing using `readFields`. Co-authored-by: VeryMilkyJoe <jana.chadt@nets.at>
VeryMilkyJoe
force-pushed
the
enhance/cabal-readfields
branch
from
5f70b19
to
ffc5942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the more brittle parser with cabal's
readFields.Ready for review :)