Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-approve Dependabot PRs #4021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@jhrcek
Copy link
Collaborator

jhrcek commented Jan 28, 2024

Just a heads up that I recently saw some version bump reverts recently, so it might not be good idea to always "blindly" accept changes to latest version.
Example
01413e1

Maybe @wz1000 can comment in on this PR too?

@peterbecich
Copy link
Member Author

Good point, another example #3815 (comment)

@wz1000
Copy link
Collaborator

wz1000 commented Jan 28, 2024

yes, we can't make any bumps that require upgrading node as the node 20 binaries it pulls in don't work on distributions with older GLIBC versions, which we need to build release binaries.

@michaelpj
Copy link
Collaborator

Yeah, in normal times this would be useful, but at the moment we are a bit blocked. Perhaps we can explicitly tell dependabot not to update those things for now?

@wz1000 do we have any way to ever get past this problem?

@wz1000
Copy link
Collaborator

wz1000 commented Jan 28, 2024

I don't know, perhaps we can convince it to get nodejs binaries from a different source where they are compiled with older GLIBC support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants