Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add outOfScopeOn completion option #3646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oberblastmeister
Copy link

This allows someone to disable out of scope completions to improve performance and accuracy.

@fendor
Copy link
Collaborator

fendor commented Jun 11, 2023

What this aims to do essentially is to only have suggestions for things that are actually in scope. So, no completions from third-party dependencies if the module hasn't been explicitly imported. This, seemingly, makes the IDE experience better for expert users.

The idea is that this is for expert users only, by default, we still suggest items that are not imported right now, but might fit.

@michaelpj
Copy link
Collaborator

Generally I think we're trying to avoid this kind of configurability? Can we not do something like just putting them at the bottom of the list? Or adding some text to the label text that makes it clear they'll require an import?

@fendor
Copy link
Collaborator

fendor commented Jun 11, 2023

That is indeed also true.

This is purely about performance I think, so no, just listing them at the bottom is likely not enough.

@fendor fendor mentioned this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants