Add NoImplicitPrelude to buildTypeScript #9988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
sheaf
force-pushed
the
no-implicit-prelude-setup
branch
from
3750653
to
1404b5b
Compare
ffaf1
approved these changes
May 8, 2024
alt-romes
added
merge me
sheaf
force-pushed
the
no-implicit-prelude-setup
branch
from
1404b5b
to
912b97e
Compare
geekosaur
approved these changes
May 8, 2024
sheaf
force-pushed
the
no-implicit-prelude-setup
branch
3 times, most recently
from
42162d6
to
4e5eb21
Compare
sheaf
added
attention: needs-review
and removed
merge me
sheaf
force-pushed
the
no-implicit-prelude-setup
branch
3 times, most recently
from
62f71c8
to
536f955
Compare
|
@sheaf: would you like a re-review, or do you just signal that the version now in the PR is different than reviewed? |
I'm waiting to see whether this new version passes CI. If it does then I will request re-review, otherwise I will roll it back. |
sheaf
force-pushed
the
no-implicit-prelude-setup
branch
2 times, most recently
from
b83e978
to
4a84f6c
Compare
|
I'm re-requesting a review. The new change since the first version is that we also stop provisioning a |
alt-romes
approved these changes
May 9, 2024
ffaf1
approved these changes
May 9, 2024
alt-romes
added
merge me
geekosaur
approved these changes
May 9, 2024
mergify
bot
added
the
merge delay passed
This allows us to compile Setup.hs without depending on base. In particular, this ensures that a package with `build-type: Hooks` and a custom setup stanza that does not depend on base successfully compiles. Tested in PackageTests/SetupHooks/SetupHooksNoBase.
Mikolaj
force-pushed
the
no-implicit-prelude-setup
branch
from
4a84f6c
to
42b8dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to compile Setup.hs without depending on base. In particular, this ensures that a package with
build-type: Hooksand a custom setup stanza that does not depend on base successfully compiles.Tested in
PackageTests/SetupHooks/SetupHooksNoBase.Template B: This PR does not modify behaviour or interface