Refactor Rebuild monad into writer over sets #9843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
force-pushed
the
push-qxoywvmpvrty
branch
from
da19bf1
to
c72fbea
Compare
5 tasks
geekosaur
reviewed
Mar 26, 2024
| -> [MonitorFilePath] | ||
| -> IO MonitorStateFileSet | ||
| go !singlePaths !globPaths [] = | ||
| return (MonitorStateFileSet (reverse singlePaths) (reverse globPaths)) | ||
| return (MonitorStateFileSet singlePaths globPaths) |
There was a problem hiding this comment.
This worries me: reverse implies the ordering is significant. (I know it's reversing because it uses : to prepend paths, but that still means the original path order is considered important enough to reconstruct afterward.)
There was a problem hiding this comment.
Yeah, this worried me a bit too. I figure this was just out of habit, but I might be wrong.
edmundnoble
force-pushed
the
push-qxoywvmpvrty
branch
from
c72fbea
to
be2695f
Compare
|
What's the status of this one (note that #9844 depends on it)? If a design discussion would be prudent before merging one or the other PR, please don't hesitate to open an issue ticket and mark it with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the following checklist in your PR:
I noticed that this seemed like a more natural way for the Rebuild monad to work. Perhaps this even saves us some file watching, I didn't look into it that deeply.