Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Features" section improvements #284

Closed
wants to merge 3 commits into from

Conversation

enmcarv
Copy link
Contributor

@enmcarv enmcarv commented Sep 28, 2023

This PR proposes:

  • removing unused code from home.js
  • changing the copy of the features section's collapse buttons to say “Show more”
  • change collapse buttons to have a different copy when toggled (“Show less”)

What do you all think of the copy changes? I think this is a slight improvement from “Click to expand” since the styling of the link already indicates the user can click there. Alternatively, we could have “Click to expand” and “Click to hide”.

An outstanding issue is that each feature should probably indicate that it can be clicked to toggle collapse outside the link button. Once resolved, there might not be a need for a separate button. A designer's opinion would be great 😅

Screenshot from 2023-09-28 16-28-39

Screencast.from.2023-09-28.16-28-52.webm

@enmcarv enmcarv changed the title Home scripts "Features" section improvements Sep 28, 2023
Copy link
Member

@TikhonJelvis TikhonJelvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I like the way "show more" looks and it seems just as clear as the previous wording.

@enmcarv enmcarv closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants