Build with haskell-bitcoin #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Crypto/Secp256k1.hs
Outdated
| @@ -395,6 +479,17 @@ exportSignatureDer (Signature fptr) = unsafePerformIO $ do | |||
| unsafePackByteString (outBuf, len) | |||
|
|
|||
|
|
|||
| -- | Convert signature to a normalized lower-S form. 'Nothing' indicates that it | |||
| -- was already normal. | |||
| normalizeSignature :: Signature -> Maybe Signature | |||
There was a problem hiding this comment.
It seems like it would be more ergonomic to have the signature Signature -> (Bool, Signature) where the bool signals whether the signature return parameter is the original or a modified signature.
There was a problem hiding this comment.
Changed it. I also thought it was a bit awkward when copying it over from secp256k1-haskell.
|
Yeah I think we're trying to ditch cereal as a dependency throughout this stack so I'm definitely gonna bias against merging this directly but we should keep it around as a template that we can rebase onto master after haskoin#31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to get haskell-bitcoin to use this library. I'm using these changes locally as I've needed some of the Schnorr bindings upstream. I don't expect this to get merged as I've added some questionable dependencies and instances to get them to build together with minimal changes. Happy to close this once #31 is complete.
Related: haskell-bitcoin changes