Call VDS callbacks on VaultAuth and VaultConnection changes #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
changed the title
benashz
force-pushed
the
VAULT-27003/fix-vaultAuth-changes-lead-to-lease-expiry
branch
from
4cf9e0d
to
1aaefc6
Compare
|
LGTM. Let me know when the update for integration tests is in. I can continue the review then. |
Updated with bb331e3 |
benashz
deleted the
VAULT-27003/fix-vaultAuth-changes-lead-to-lease-expiry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some internal work we discovered that when updating a
VaultAuthinstance, any associated Vault Clients are pruned from the cache without notifying theVaultDynamicSecretscontroller. This could potentially lead to premature revocation of secret leases, causing service disruptions for applications that rely on valid secret data.Upon update to a
VaultAuthorVaultClientinstance, theCachingClientFactorywill send any pruned Clients to itscallbackHandlerchannel. Upon deletion of either resource, the Client will be removed from the cache and no callbacks will be called.