CachingClientFactory: support client taints #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secret reconcilers have no way of advising the CachingClientFactory that a Client might be invalid. Now a reconciler can taint the Client if a Vault operation fails for some reason. The common case is where a Vault request resulted in a 403 (forbidden) status code. In this case the reconciler can taint the client so that the next call to factory for the tainted client will have the factory validate that the client's token is still valid by performing reaching out to Vault's lookup lookup API. Client taints should be used sparingly, since they can increase the number of requests to Vault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secret reconcilers have no way of advising the CachingClientFactory that a Client might be invalid. Now a reconciler can taint the Client if a Vault operation fails for some reason. The common case is where a Vault request resulted in a 403 (forbidden) status code. In this case the reconciler can taint the client so that the next call to factory for the tainted client will have the factory check that the client's token is still valid by reaching out to Vault's lookup lookup API. Client taints should be used sparingly, since they can increase the number of requests to Vault.