Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: add support for configuring strategy on controller deployment #709

Merged
merged 3 commits into from May 22, 2024

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Apr 25, 2024

Implement issue #692

@sebglon sebglon requested a review from a team as a code owner April 25, 2024 13:01
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please take a look at my suggestions that need to be resolved before merging.

chart/values.yaml Outdated Show resolved Hide resolved
chart/values.yaml Show resolved Hide resolved
chart/templates/deployment.yaml Outdated Show resolved Hide resolved
chart/templates/deployment.yaml Outdated Show resolved Hide resolved
@sebglon sebglon requested a review from benashz May 6, 2024 09:54
@benashz benashz merged commit 3fc249e into hashicorp:main May 22, 2024
1 check passed
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution to HashiCorp.

@benashz benashz added this to the v0.7.0 milestone May 22, 2024
@benashz benashz changed the title feat(helm): add update strategy on controller deployment Helm: add support for configuring strategy on controller deployment May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants