stacks: support unknown for_each on embedded stacks #35119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfagerlund
approved these changes
May 8, 2024
| @@ -190,7 +190,10 @@ func TestStackCallCheckInstances(t *testing.T) { | |||
| // when we know there are zero instances, which would be a non-nil | |||
| // empty map. | |||
| gotInsts, diags := call.CheckInstances(ctx, InspectPhase) | |||
| assertNoDiags(t, diags) | |||
There was a problem hiding this comment.
Oh. 😆 yeah, makes sense for CheckInstances to check the for_each value. I'm surprised it didn't before.
internal/stacks/stackruntime/internal/stackeval/stack_call_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>
Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Target Release
1.8.x
Draft CHANGELOG entry
NEW FEATURES