Wrong reference

[danielthorvil]

I think line 249 is meaning to reference to the "when" functionality, not the "on_failure" functionality.

Fixes #

Target Release

1.8.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

[hashicorp-cla-app]

All committers have signed the CLA.

[crw]

Thanks for this submission!

[crw]

Given the way the rest of this document is written, I believe the original text is actually what is intended (even though the next section is on when, there is in fact a section farther down describing on_failure). If you think this is incorrect, please let me know and I will also run this past another person on the team just to check my thinking. Thanks!

[trujillo-adam]

Thanks for calling attention to this. It is very easy to see how the original text is ambiguous. We need to do a better job of following our own style guide. I think these suggestions will clear things up.

[crw]

Approving after merging trujillo-adam's changes

[crw]

Hi @danielthorvil, I went ahead and committed those changes and approved this PR based on the new changes. I am going to merge this PR, if you feel there is anything else you want to change please feel free to open a new PR. Thanks very much!

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.